-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: unable to use CRDs imported as modules #3897
Conversation
Signed-off-by: bany <[email protected]>
@9bany could you please update the PR to fix the conflict and push changes? |
Signed-off-by: bany <[email protected]>
for more information, see https://pre-commit.ci
@9bany thank you for contributing! Great work! Could you please resolve conflict and push your changes? We would be happy to merge your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 LGTM
Signed-off-by: bany <[email protected]>
@9bany could you please run ➜ kubernetes-ingress git:(9bany/main) make lint
// output partially omitted
internal/k8s/controller.go:27: File is not `gofmt`-ed with `-s` (gofmt)
"github.com/nginxinc/kubernetes-ingress/v3/pkg/apis/dos/v1beta1"
"golang.org/x/exp/maps"
INFO File cache stats: 1 entries of total size 143.7KiB
INFO Memory: 12 samples, avg is 43.7MB, max is 89.7MB
INFO Execution took 1.094010333s
make: *** [lint] Error 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
@9bany could you please update branch push your changes? |
@9bany could you please open (change this PR) a PR from your fork and the branch name different than NGINX:main <- 9bany:module-support where more info: https://github.com/nginxinc/kubernetes-ingress/blob/main/CONTRIBUTING.md#open-a-pull-request |
@9bany any update on this? Would you be able to send 2nd PR from your branch different than |
I will fight back on Monday, thanks for your support @jjngx |
thanks @9bany , I will start working on your PR soon. |
@9bany thank you for contributing! One question, as part of your testing did you run code generators? They can be executed using the following make targets: $ make
...
update-codegen Generate code
update-crds Update CRDs
verify-codegen Verify code generation
... |
@jjngx |
Proposed changes
/v3
Checklist
Before creating a PR, run through this checklist and mark each as complete.